etcd_docker 5: Incorporate docker based etcd approach into docker integration tests. #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2022
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
e0944c8
to
914ac93
Compare
andrewmains12
changed the title
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
8445afb
to
e639964
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
2 times, most recently
from
78835f0
to
cb8db85
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
50a14e2
to
77ca046
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
cb8db85
to
0ef0995
Compare
justinjc
reviewed
Aug 30, 2022
scripts/docker-integration-tests/prometheus_replication/test.sh
Outdated
Show resolved
Hide resolved
scripts/docker-integration-tests/prometheus_replication/docker-compose.yml
Outdated
Show resolved
Hide resolved
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
0ef0995
to
73e9f32
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
77ca046
to
d7b617c
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
3 times, most recently
from
87111b2
to
364111f
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
16b5b60
to
6910f1e
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
364111f
to
2b6636a
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
6910f1e
to
c8b6a12
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
2 times, most recently
from
6d9b5bd
to
c165783
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
0580883
to
b47a381
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
c165783
to
18efb5b
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
b47a381
to
9398782
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
2 times, most recently
from
12ed8fb
to
f41faba
Compare
justinjc
reviewed
Aug 31, 2022
|
|
||
| function defer { | ||
| docker-compose -f ${COMPOSE_FILE} down || echo "unable to shutdown containers" # CI fails to stop all containers sometimes | ||
| : | ||
| # docker-compose -f ${COMPOSE_FILE} down || echo "unable to shutdown containers" # CI fails to stop all containers sometimes |
There was a problem hiding this comment.
Do we not need this anymore? If not, why not just remove the entire function the the trap defer EXIT below?
Base automatically changed from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
to
uber/20220830-grpc_update
September 2, 2022 14:50
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
f41faba
to
8778662
Compare
justinjc
approved these changes
Sep 2, 2022
…egration tests. PR 5 for #4144 This PR makes the docker integration tests use containerized etcd. Previously, these relied on M3DB running an embbeded etcd server. There's no inherent need for this, and it opens us up to dependency issues as described in the linked github issue. Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those back at a later date.. commit-id:e67a5172
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
8778662
to
4b8bede
Compare
|
✓ Commit merged in pull request #4150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 5 for #4144
This PR makes the docker integration tests use containerized etcd.
Previously, these relied on M3DB running an embbeded etcd server.
There's no inherent need for this, and it opens us up to dependency issues as described
in the linked github issue.
Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those
back at a later date..
Stack: