Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd_docker 6: Remove etcd embed from M3DB node #4150

Merged
merged 2 commits into from
Sep 2, 2022
Merged

etcd_docker 6: Remove etcd embed from M3DB node #4150

merged 2 commits into from
Sep 2, 2022

Commits on Sep 2, 2022

  1. etcd_docker 5: Incorporate docker based etcd approach into docker int… 

    …egration tests.

PR 5 for #4144

This PR makes the docker integration tests use containerized etcd.
Previously, these relied on M3DB running an embbeded etcd server.

There's no inherent need for this, and it opens us up to dependency issues as described
in the linked github issue.

Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those
back at a later date..

commit-id:e67a5172
    @andrewmains12
    andrewmains12 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    4b8bede View commit details
    Browse the repository at this point in the history

  2. etcd_docker 6: Remove etcd embed from M3DB node 

    PR 6 for #4144

Now that all test usages of the embed package had been removed, this PR removes
the usage of the embed package from the m3db server itself.

N.B.: this PR currently makes no attempt to fix up any "quick start" flows relying on embedded etcd; that will
come later.

commit-id:2870a75c
    @andrewmains12
    andrewmains12 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    649f48c View commit details
    Browse the repository at this point in the history