Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildkite] Fix lint test in buildkite pipeline #4280

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Conversation

kentzeng12
Copy link
Collaborator

What this PR does / why we need it:
This PR fixes failing lint test in buildkite pipeline.

Fixes #4274

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
No

Does this PR require updating code package or user-facing documentation?:
No

@andrewmains12
Copy link
Contributor

Why are there code changes in this PR? Shouldn't the lint that was passing before still pass?

Copy link
Contributor

@andrewmains12 andrewmains12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline: the code changes are to fix lint errors introduced in the meantime.

@kentzeng12 kentzeng12 merged commit 9a4b26a into master Jul 25, 2024
5 checks passed
@kentzeng12 kentzeng12 deleted the zengk/buildkite_lint branch July 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildkite pipeline is broken
2 participants