Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native pooling #870

Merged
merged 5 commits into from
Aug 30, 2018
Merged

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Aug 30, 2018

Native pooling has only ever been experimental, this change removes the possibility of using it.

We do not wish to support it at this time.

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #870 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   78.35%   78.39%   +0.03%     
==========================================
  Files         391      391              
  Lines       33294    33287       -7     
==========================================
+ Hits        26087    26094       +7     
+ Misses       5406     5399       -7     
+ Partials     1801     1794       -7
Flag Coverage Δ
#dbnode 81.4% <100%> (+0.06%) ⬆️
#m3ninx 71.99% <ø> (ø) ⬆️
#query 67.45% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399d904...d6652aa. Read the comment docs.

Copy link
Collaborator

@prateek prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title Disable dbnode native pooling when using config Remove native pooling Aug 30, 2018
@robskillington robskillington merged commit 606981d into master Aug 30, 2018
@robskillington robskillington deleted the r/disable-native-pooling-from-config branch August 30, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants