Set namespace and ID as NoFinalize #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the session to avoid cloning these on the WriteTagged operation, which will save two allocations for each datapoint
| @@ -257,6 +257,8 @@ func (s *m3storage) Write( | |||
| id := query.Tags.ID() | |||
| // TODO: Consider caching id -> identID | |||
There was a problem hiding this comment.
Caching these in an LRU would actually probably save a ton of allocs unrelated to this P.R
There was a problem hiding this comment.
I think there's some other refactoring of this going on in #942, so don't want to step on any toes there and lead to messy merges; we'll definitely circle back on adding an LRU here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the session to avoid cloning these on the WriteTagged
operation, which will save two allocations for each datapoint