Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] fix incorrect label selectors #100

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

schallert
Copy link
Collaborator

We had been constructing the wrong selectors when querying children
pods if the cluster had custom labels.

We had been constructing the wrong selectors when querying children
pods if the cluster had custom labels.
@schallert schallert force-pushed the schallert/fix_cluster_label_selector branch from 67f2a0e to d4bab48 Compare March 10, 2019 03:24
Copy link
Contributor

@nerd0 nerd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert merged commit d078cbc into master Mar 11, 2019
@schallert schallert deleted the schallert/fix_cluster_label_selector branch March 11, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants