[api] support custom node affinity per-isogroup #106
Conversation
Previously we had been using the name of an IsolationGroup as its the value selector in a StatefulSet's NodeAffinity, with the key hardcoded to `failure-domain.beta.kubernetes.io/zone`. This meant that users had to have clusters across 3 unique zones. This relaxes those constraints and allows users to specify the NodeAffinity selectors they wish to use, meaning they can have clusters within a single zone or other failure domain.
schallert
force-pushed
the
schallert/sts_isogroup_new
branch
4 times, most recently
from
236ac4e
to
2f6c77d
Compare
schallert
force-pushed
the
schallert/sts_isogroup_new
branch
from
2f6c77d
to
63a56cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 67.63% 68.16% +0.53%
==========================================
Files 26 26
Lines 1894 1888 -6
==========================================
+ Hits 1281 1287 +6
+ Misses 510 501 -9
+ Partials 103 100 -3Continue to review full report at Codecov.
|
| @@ -98,10 +97,6 @@ func main() { | |||
|
|
|||
| defer logger.Sync() | |||
|
|
|||
| logger.Info("Go", zap.Any("VERSION", runtime.Version())) | |||
There was a problem hiding this comment.
Since I added the m3x build reporter we get all of this info for free in a startup log from there
| ) | ||
|
|
||
| var ( | ||
| errEmptyConfigMap = errors.New("ConfigMapName cannot be empty if non-nil") | ||
| ) | ||
|
|
||
| // EnsurePlacement ensures that a placement exists otherwise create one |
There was a problem hiding this comment.
I assume this code was replaced beforehand, didn't see it replaced within this PR.
There was a problem hiding this comment.
Yeah turns out I couldn't find it used anywhere
scripts/run_e2e_tests.sh
Outdated
| @@ -46,7 +46,7 @@ function main() { | |||
|
|
|||
| trap cleanup EXIT | |||
|
|
|||
| kubectl proxy & | |||
| kubectl proxy &>/dev/null & | |||
There was a problem hiding this comment.
Why silence the output, couldn't it help if the test borks?
There was a problem hiding this comment.
So the annoying this was this would interleave the proxy output with the test and it was confusing what was coming from where, but I guess that's better than nothing so will re-add
There was a problem hiding this comment.
You could consider something like:
kubectl proxy |sed -e 's/^/kube proxy: /'&
| @@ -98,10 +97,6 @@ func main() { | |||
|
|
|||
| defer logger.Sync() | |||
|
|
|||
| logger.Info("Go", zap.Any("VERSION", runtime.Version())) | |||
Previously we had been using the name of an IsolationGroup as its
the value selector in a StatefulSet's NodeAffinity, with the key
hardcoded to
failure-domain.beta.kubernetes.io/zone. This meant thatusers had to have clusters across 3 unique zones.
This relaxes those constraints and allows users to specify the
NodeAffinity selectors they wish to use, meaning they can have clusters
within a single zone or other failure domain.
Fixes #68