[api] allow specifying pod tolerations #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 68.55% 68.56% +0.01%
==========================================
Files 26 26
Lines 1873 1874 +1
==========================================
+ Hits 1284 1285 +1
Misses 489 489
Partials 100 100Continue to review full report at Codecov.
|
schallert
force-pushed
the
schallert/tolerations
branch
from
789bd3f
to
db5704d
Compare
Some users wish to use taints/tolerations to pin M3DB instances to dedicated nodes, and keep other pods off of them. This allows specifying tolerations in the cluster spec. Note that we currently allow specifying tolerations on the cluster level and not the `isolationgroup` level, as it seems like most common use cases would be setting aside nodes for M3DB using a single taint rather than a per-zone taint. If user requests for per-isogroup tolerations arise we can reconsider.
schallert
force-pushed
the
schallert/tolerations
branch
from
db5704d
to
9af4f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users wish to use taints/tolerations to pin M3DB instances to
dedicated nodes, and keep other pods off of them. This allows specifying
tolerations in the cluster spec.
Note that we currently allow specifying tolerations on the cluster level
and not the
isolationgrouplevel, as it seems like most common usecases would be setting aside nodes for M3DB using a single taint rather
than a per-zone taint. If user requests for per-isogroup tolerations
arise we can reconsider.