[config] set new default m3db bootstrapper config #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M3DB recently changed the default configuration to add `returnUnfulfilledForCorruptCommitLogFiles: false` by default. This makes it easier to recover from catastrophic cluster failures, so we'll set this by default. More from the M3DB docs: https://docs.m3db.io/operational_guide/availability_consistency_durability/
|
@richardartoul if you have any thoughts on other defaults we should update would love to hear them! |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 68.48% 68.37% -0.11%
==========================================
Files 26 26
Lines 1869 1869
==========================================
- Hits 1280 1278 -2
- Misses 489 490 +1
- Partials 100 101 +1Continue to review full report at Codecov.
|
richardartoul
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
LGTM, I think this should be the default. Maybe add a link to https://docs.m3db.io/operational_guide/availability_consistency_durability/ somewhere (above this line or elsewhere)
schallert
force-pushed
the
schallert/new_defaults
branch
from
76a0e13
to
b4a3cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M3DB recently changed the default configuration to add
returnUnfulfilledForCorruptCommitLogFiles: falseby default. Thismakes it easier to recover from catastrophic cluster failures, so we'll
set this by default.
More from the M3DB docs: https://docs.m3db.io/operational_guide/availability_consistency_durability/