[m3admin] non-strict jsonpb unmarshalling #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we unmarshal responses from the m3coordinator, the default jsonpb behavior is to not allow unknown fields. This means that new fields added by m3db to the proto can break the operator. This fixes that and future-proofs us against new fields.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 68.48% 68.55% +0.06%
==========================================
Files 26 26
Lines 1869 1873 +4
==========================================
+ Hits 1280 1284 +4
Misses 489 489
Partials 100 100Continue to review full report at Codecov.
|
This was referenced Apr 25, 2019
robskillington
pushed a commit
that referenced
this pull request
Jul 17, 2019
When we unmarshal responses from the m3coordinator, the default jsonpb behavior is to not allow unknown fields. This means that new fields added by m3db to the proto can break the operator. This fixes that and future-proofs us against new fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we unmarshal responses from the m3coordinator, the default jsonpb
behavior is to not allow unknown fields. This means that new fields
added by m3db to the proto can break the operator. This fixes that and
future-proofs us against new fields.