[controller] continuously reconcile configmaps #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have a default template for configmaps that we construct for users, we should continuously reconcile it. This will allow us to roll out new config for M3DB over time and know that users' clusters will pick up our changes. This logic doesn't trigger if the user has a custom configmap.
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 68.56% 68.65% +0.08%
==========================================
Files 26 26
Lines 1874 1895 +21
==========================================
+ Hits 1285 1301 +16
- Misses 489 491 +2
- Partials 100 103 +3Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a default template for configmaps that we construct for
users, we should continuously reconcile it. This will allow us to roll
out new config for M3DB over time and know that users' clusters will
pick up our changes.
This logic doesn't trigger if the user has a custom configmap.