[controller] fix pod removal when diff > 1 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
+ Coverage 68.67% 68.77% +0.1%
=========================================
Files 26 26
Lines 1896 1909 +13
=========================================
+ Hits 1302 1313 +11
- Misses 491 493 +2
Partials 103 103Continue to review full report at Codecov.
|
There was a bug in the instance removal logic that would continuously try to remove the last pod in a set even if it had already been removed from the placement. This fixes that. Tested by creating a cluster w/ 3 reps, 1 node each. Scaled each rep to 9, then back down to 1.
schallert
force-pushed
the
schallert/fix_multi_remove
branch
from
df3344a
to
40110ad
Compare
schallert
commented
Apr 19, 2019
pkg/controller/controller.go
Outdated
| current := *set.Spec.Replicas | ||
| // Nunber of instances currently in the placement. |
pkg/controller/update_cluster.go
Outdated
| for i := len(podIDs) - 1; i >= 0; i-- { | ||
| pod := podIDs[i].pod | ||
| inst, err := c.findPodInPlacement(cluster, pl, pod) | ||
| if err == errPodNotInPlacement { |
There was a problem hiding this comment.
Cause() on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the instance removal logic that would continuously
try to remove the last pod in a set even if it had already been removed
from the placement. This fixes that.