Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[health] use dbnode health/bootstrap endpoints #135

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

schallert
Copy link
Collaborator

Now that M3DB exposes health and bootstrapped endpoints immediately we
can leverage those rather than the crazy health check script.

@schallert
Copy link
Collaborator Author

Not to be merged until next release of M3DB.

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   73.79%   73.82%   +0.02%     
==========================================
  Files          26       26              
  Lines        1893     1895       +2     
==========================================
+ Hits         1397     1399       +2     
  Misses        393      393              
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd30b43...6a2a293. Read the comment docs.

@schallert schallert force-pushed the schallert/http_healthcheck branch from d59fa5a to 9a37cfa Compare May 2, 2019 21:39
@robskillington
Copy link
Collaborator

This should be calling the /bootstrappedinplacementornoplacement endpoint I believe?

Now that M3DB exposes health and bootstrapped endpoints immediately we
can leverage those rather than the crazy health check script.
@schallert schallert marked this pull request as ready for review June 7, 2019 21:58
@schallert schallert merged commit 02b5e6e into master Jun 7, 2019
@schallert schallert deleted the schallert/http_healthcheck branch June 7, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants