Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration script #143

Merged
merged 2 commits into from
May 17, 2019
Merged

Conversation

schallert
Copy link
Collaborator

  • remove new line char from etcd get
  • remove key name from etcd get
  • -i flag required on kubectl exec
  • correct version numbers in comments

Arnaud Meyer and others added 2 commits May 17, 2019 16:25
- remove new line char from etcd get
- remove key name from etcd get
- -i flag required on kubectl exec
- correct version numbers in comments
Co-authored-by: Arnaud Meyer <arnaud.meyer@idealo.de>
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #143   +/-   ##
======================================
  Coverage    71.9%   71.9%           
======================================
  Files          26      26           
  Lines        1808    1808           
======================================
  Hits         1300    1300           
  Misses        406     406           
  Partials      102     102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165bee3...37d5987. Read the comment docs.

@schallert schallert merged commit 9e4dff1 into master May 17, 2019
@schallert schallert deleted the schallert/arnaud_fix_migration_script branch May 17, 2019 20:20
@schallert schallert mentioned this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant