Always create missing stateful sets #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robskillington
commented
May 30, 2019
•
robskillington
commented
- Tests
robskillington
force-pushed
the
r/always-create-missing-stateful-sets
branch
from
e857230
to
d96104b
Compare
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 73.82% 74.86% +1.04%
==========================================
Files 26 26
Lines 1895 1898 +3
==========================================
+ Hits 1399 1421 +22
+ Misses 393 364 -29
- Partials 103 113 +10Continue to review full report at Codecov.
|
|
Looks good so far 👍 |
|
I'm working on merging this now, just rebasing with my etcd data deletion changes |
Add tests for creating missing stateful sets Rename test refactor test
schallert
force-pushed
the
r/always-create-missing-stateful-sets
branch
from
f9d59e8
to
7871f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.