Use patch instead of update for resources not owned by operator #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 72.82% 72.82%
=======================================
Files 28 28
Lines 2186 2186
=======================================
Hits 1592 1592
Misses 451 451
Partials 143 143Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the issue we were seeing with Pod updates being rejected when deep copying then calling Update.
I also updated all other places we were doing copies then calling update to use patches (with the exception of our own CRDs since I figure we own the lifecycle and are in control of that).
These implementations follow the implementation of generating patches that the postgres operator follows.