Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Allow overriding node endpoint format #183

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Conversation

schallert
Copy link
Collaborator

Allows users to access the M3DB cluster from other Kubernetes namespaces
by overriding the endpoint format.

Allows users to access the M3DB cluster from other Kubernetes namespaces
by overriding the endpoint format.
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #183 into master will decrease coverage by 0.04%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   74.38%   74.33%   -0.05%     
==========================================
  Files          28       28              
  Lines        1956     1968      +12     
==========================================
+ Hits         1455     1463       +8     
- Misses        383      385       +2     
- Partials      118      120       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0e0bf...4a09dc3. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington marked this pull request as ready for review January 16, 2020 13:43
@schallert schallert merged commit 1043ba7 into master Jan 22, 2020
@schallert schallert deleted the schallert/endpoint_ns branch January 22, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants