Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[m3admin] Add topic client #190

Merged
merged 2 commits into from
Jan 31, 2020
Merged

[m3admin] Add topic client #190

merged 2 commits into from
Jan 31, 2020

Conversation

schallert
Copy link
Collaborator

Allows for automation of topics in the future.

  • Update M3 dependency version.
  • Support per-request headers in m3admin client (necessary to send topic
    name).

Allows for automation of topics in the future.

- Update M3 dependency version.
- Support per-request headers in m3admin client (necessary to send topic
  name).
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #190 into master will increase coverage by 1.06%.
The diff coverage is 93.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   74.11%   75.17%   +1.06%     
==========================================
  Files          28       30       +2     
  Lines        1974     2087     +113     
==========================================
+ Hits         1463     1569     +106     
- Misses        388      391       +3     
- Partials      123      127       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc2f05...7a4a196. Read the comment docs.

@schallert schallert marked this pull request as ready for review January 31, 2020 12:56
@schallert schallert merged commit bf57144 into master Jan 31, 2020
@schallert schallert deleted the schallert/topic_client branch January 31, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant