[controller] Don't update Status if noop #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic causes some Statuses to get updated even if they haven't changed. This causes an update storm, where updating the status causes the cluster to be re-enqueued for processing and then have its status updated again. This puts unnecessary load on the API server and operator.
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 75.42% 75.40% -0.03%
==========================================
Files 30 30
Lines 2112 2118 +6
==========================================
+ Hits 1593 1597 +4
- Misses 392 393 +1
- Partials 127 128 +1 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic causes some Statuses to get updated even if they
haven't changed. This causes an update storm, where updating the status
causes the cluster to be re-enqueued for processing and then have its
status updated again. This puts unnecessary load on the API server and
operator.