Create missing statefulsets before waiting for ready #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 73.87% 73.87%
=======================================
Files 30 30
Lines 2247 2247
=======================================
Hits 1660 1660
Misses 453 453
Partials 134 134 Continue to review full report at Codecov.
|
schallert
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means if statefulsets go missing for whatever reason they can be recreated and nodes can bootstrap all at once instead of waiting for all replicas to be ready in a single replica before progressing to creating the next statefulset.
Very useful in disaster scenarios and/or dev when recreating statefulsets and having the nodes come back quickly after statefulset deletions.