[m3admin-client] Incorporate zone into client cache #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, we could reuse clients without the proper zone header set, meaning etcd writes could be misdirected when cluster specs change during the duration of the operator's lifetime.
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 32 32
Lines 2548 2548
=======================================
Hits 1939 1939
Misses 430 430
Partials 179 179 Continue to review full report at Codecov.
|
schallert
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we could reuse clients without the proper zone header set, meaning etcd writes could be misdirected when cluster specs change during the duration of the operator's lifetime.