Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang:1.16-alpine3.13 as build image #306

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

jeromefroe
Copy link
Collaborator

This commit updates the Docker image we use to build the m3db-operator to golang:1.16-alpine3.13. The current image, golang:1.16-alpine, uses Alpine 3.14 which requires at least Docker 20.10.0 in order to pick up a fix for an issue with the faccessat2 syscall in Alpine Linux 3.14. Longer term we should update CI to use a newer version of Docker but in the interim this commit just uses an image with Alpine 3.13.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #306 (1cd74a0) into master (f919dd9) will not change coverage.
The diff coverage is n/a.

❗ Current head 1cd74a0 differs from pull request most recent head dd567b9. Consider uploading reports for the commit dd567b9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files          32       32           
  Lines        2571     2571           
=======================================
  Hits         1955     1955           
  Misses        437      437           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f919dd9...dd567b9. Read the comment docs.

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromefroe jeromefroe merged commit ab41411 into master Oct 25, 2021
@jeromefroe jeromefroe deleted the jerome/use-different-go-image branch October 25, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants