Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent scaling down to 0 instances #316

Merged
merged 1 commit into from
Mar 16, 2022
Merged

prevent scaling down to 0 instances #316

merged 1 commit into from
Mar 16, 2022

Conversation

Antanukas
Copy link
Collaborator

After discussing with Linas we agreed that scaling to 0 does not really makes sense and probably won't work. Since placement needs to be discarded.

linasm
linasm approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@linasm linasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Antanukas Antanukas merged commit 9758b96 into master Mar 16, 2022
@Antanukas Antanukas deleted the antanas/prevent-zero-desired-instances branch March 16, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromefroe jeromefroe jeromefroe approved these changes

@linasm linasm linasm approved these changes

@schallert schallert Awaiting requested review from schallert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antanukas @linasm @jeromefroe