[api] cluster spec etcd endpts; per-cluster envs #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerd0
reviewed
Mar 7, 2019
docs/api.md
Outdated
| @@ -43,7 +43,8 @@ ClusterSpec defines the desired state for a M3 cluster to be converge to. | |||
| | numberOfShards | NumberOfShards defines how many shards in total | int32 | false | | |||
| | isolationGroups | IsolationGroups specifies a map of key-value pairs. Defines which isolation groups to deploy persistent volumes for data nodes | [][IsolationGroup](#isolationgroup) | false | | |||
| | namespaces | Namespaces specifies the namespaces this cluster will hold. | [][Namespace](#namespace) | false | | |||
| | configMapName | ConfigMapName specifies the ConfigMap to use for this cluster. If unset a sane default will be used. | *string | false | | |||
| | etcdEndpoints | EtcdEndpoints defines the etcd endpoints to use for service discovery. Must be set if no custom configmap is defined. If set, etcd endpoints will be templated in to the default configmap template. | []string | false | | |||
| | configMapName | ConfigMapName specifies the ConfigMap to use for this cluster. If unset a default configmap with template variables for etcd endpoints will be used. | *string | false | | |||
There was a problem hiding this comment.
should we link the default template that will be used as default-config above?
There was a problem hiding this comment.
Ah yeah good point. I think I'll add a comment saying "see configuration section of docs" just so we don't have too many links in the comments
| m.logger, | ||
| } { | ||
| assert.NotNil(t, v) | ||
| } | ||
| } | ||
|
|
||
| func newM3DBCluster(name string) *myspec.M3DBCluster { | ||
| func newM3DBCluster(ns, name string) *myspec.M3DBCluster { |
There was a problem hiding this comment.
Is this assuming a 1:1 association of namespace to cluster?
There was a problem hiding this comment.
I don't think so, but it's just generating a fake metadata for the tests
schallert
force-pushed
the
schallert/m3admin_client_env
branch
from
89e05e8
to
73a07df
Compare
This PR has a few changes to improve the interaction between operator-operated M3DB clusters and etcd: 1. Users can now specify etcd endpoints on the m3dbcluster spec, removing one of the most common changes users would have to make in their config files. 2. The operator will include a per-cluster environment header in all requests to the coordinator, meaning that namespaces and placements will be stored under separate keys per-cluster in etcd and multiple m3dbclusters can share the same etcd cluster. **NOTE**: This PR introduces a breaking change that will require users to 1) rename 2 keys in their etcd clusters and 2) change a value in their configmap if they would like the operator to continue being able to manage clusters from before this commit. The changelog for this release will include instructions for this.
schallert
force-pushed
the
schallert/m3admin_client_env
branch
from
73a07df
to
89c86fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few changes to improve the interaction between
operator-operated M3DB clusters and etcd:
Users can now specify etcd endpoints on the m3dbcluster spec,
removing one of the most common changes users would have to make in
their config files.
The operator will include a per-cluster environment header in all
requests to the coordinator, meaning that namespaces and placements will
be stored under separate keys per-cluster in etcd and multiple
m3dbclusters can share the same etcd cluster.
NOTE: This PR introduces a breaking change that will require users
to 1) rename 2 keys in their etcd clusters and 2) change a value in
their configmap if they would like the operator to continue being able
to manage clusters from before this commit. The changelog for this
release will include instructions for this.
Fixes #64
Fixes #88