Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry #167

Merged
merged 9 commits into from
Jan 27, 2021
Merged

poetry #167

merged 9 commits into from
Jan 27, 2021
+1,627 −55

Conversation

vaaaaanquish
Copy link
Contributor

@hirosassa @Hi-king

$ poetry build
Building gokart (0.3.24.post1.dev0+ca04202)
  - Building sdist
  - Built gokart-0.3.24.post1.dev0+ca04202.tar.gz
  - Building wheel
  - Built gokart-0.3.24.post1.dev0+ca04202-py3-none-any.whl

$ pip install dist/gokart-0.3.24.post1.dev0+ca04202-py3-none-any.whl
...
Successfully installed gokart-0.3.24.post1.dev0+ca04202

@vaaaaanquish
Copy link
Contributor Author

vaaaaanquish commented Jan 26, 2021 •
edited
Loading

TODO

  • set secrets env
  • Disconnect the TravisCI

hirosassa
hirosassa reviewed Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@hirosassa hirosassa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few comments added

.github/workflows/publish.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Hi-king
Hi-king reviewed Jan 26, 2021
View reviewed changes
pyproject.toml
pattern = "^(?P<base>\\d+\\.\\d+\\.\\d+)"

[tool.poetry.dependencies]
python = "^3.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] Too strict? 3.6 might be OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because pandas is not supported python 3.6.
https://pypi.org/project/pandas/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Thx for that info!

Hi-king
Hi-king approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Hi-king Hi-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirosassa hirosassa mentioned this pull request Jan 26, 2021
Closed
hirosassa
hirosassa approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@vaaaaanquish
Copy link
Contributor Author

gogogo!

@vaaaaanquish vaaaaanquish merged commit 415d5f3 into master Jan 27, 2021
@hirosassa hirosassa deleted the github_actions branch July 8, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hi-king Hi-king Hi-king approved these changes

@hirosassa hirosassa hirosassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaaaaanquish @hirosassa @Hi-king