Expand declaration attributes #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/decl_attributes
branch
from
b85b0f8
to
239d1a3
Compare
added 7 commits
February 21, 2019 14:46
and, put section_index into SymbolBuilder because many users set it right after building the symbol anyway
TODO: come up with a plan to deprecate automatically making .debug_str and .debug_line_str into string sections, because theres a proper api for that now
pchickey
force-pushed
the
pch/decl_attributes
branch
from
7e9a242
to
d59a348
Compare
added 5 commits
February 22, 2019 11:57
|
Integrated with goblin changes and added a test suite. Found that failure::Error was being used in Artifact::declare instead of ArtifactError, so I switched it to that, which i think is the intention. It will coerce into failure::Error at any use sites that expect that type and use Once a reviewer approves this PR, I'll bump the faerie version to 0.8.0 and merge it. |
|
Thanks for the code review. I published on crates.io as 0.8.0. |
|
Wow this was epic great work ! I especially like the testing scaffold you added, thanks for that and all the hard work that went into this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #67
Adds attributes to each declaration that allow the user to control:
Scope { Global, Local, Weak }. Local by default,is_global()still gives a bool. Fixes Weak linkage support #60Visibility { Default, Protected, Hidden }. Default by default. Fixes External linkage + hidden visibility support #61The data type attribute means:
.debug_strand.debug_line_strsections as strings automatically. This heuristic is left in place for now to minimize breakage downstream.Additionally, non-writable data are now put in the
.rodatasegment, which means the loader will put that data in memory that is protected against writing.