elf: parse shdr_relocs even if binary type is not ET_REL #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
approved these changes
Feb 8, 2019
src/elf/mod.rs
Outdated
| } | ||
| let mut shdr_relocs = vec![]; | ||
| for (idx, section) in section_headers.iter().enumerate() { | ||
| if section.sh_type == section_header::SHT_REL { |
There was a problem hiding this comment.
Random thought, you don’t have to do it, wish we just did:
let is_rela = section.sh_type == section_header::SHT_RELA
if is_rela || section.sh_type == section_header::SHT_REL {
// code and pass is_rela to the Boolean flag in parse
}
There was a problem hiding this comment.
Yes, that seems like a good idea and it's what I have in my work around for section relocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117