Delete feature(alloc)
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature `alloc` has been stable since 1.36.0.
m4b
approved these changes
Dec 12, 2019
|
|
||
| #[cfg(feature = "std")] | ||
| extern crate core; | ||
|
|
||
| #[cfg(all(feature = "alloc", not(feature = "std")))] | ||
| #[cfg(feature = "alloc")] | ||
| #[macro_use] | ||
| extern crate alloc; |
There was a problem hiding this comment.
So this is like a “magical” external crate now, similar to core ? I just realized we had this before. And I don’t really know how it works haha
So In 1.36 what changer is that we can use this now without the alloc mod simulating it below for std targets ? (I guess stabilization means it’s available for both no_std and std configurations ?)
I should probably just read the rfc.
Anyway thanks for the refactor !
There was a problem hiding this comment.
Yes, it's the same as core, and it's always available, so we can use it all the time even for std builds on stable rust.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature
allochas been stable since 1.36.0.The main change is in lib.rs, the rest is cleanup.