Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elf: handle zero offset in SectionHeader::parse #200

Merged
merged 1 commit into from
Dec 23, 2019
Merged

elf: handle zero offset in SectionHeader::parse #200

merged 1 commit into from
Dec 23, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Dec 23, 2019

Regression in 779d0ce (which wasn't reviewed...).
Fixes #199, cc @xcoldhandsx

@anfedotoff
Copy link
Contributor

I've tested on my example and it seems, that it works, thanks.

anfedotoff
anfedotoff approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@anfedotoff anfedotoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on my example, it seems, that it works, thanks. Zero offset check solved the problem.

@m4b
Copy link
Owner

m4b commented Dec 23, 2019

Ugh m4b breaking shit. Thanks @xcoldhandsx for reporting and @philipc for fixing this !

@m4b m4b merged commit 830ee4e into m4b:master Dec 23, 2019
@philipc philipc deleted the issue-199 branch December 24, 2019 03:03
@m4b
Copy link
Owner

m4b commented Dec 28, 2019

1.3 is released with this regression fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

@anfedotoff anfedotoff anfedotoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some problems with parsing core dumps
3 participants
@philipc @anfedotoff @m4b