Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more COFF machine constants. #223

Merged
merged 1 commit into from
May 10, 2020

Conversation

ExPixel
Copy link
Contributor

@ExPixel ExPixel commented May 10, 2020

Added all of the COFF machine constants found here:
https://docs.microsoft.com/en-us/windows/win32/debug/pe-format

(sorry about the multiple pull requests)

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the PR :) @ExPixel, just curious where did you get the constants from?; @jan-auer you know a bit about PE, do these look ok to you?

@ExPixel
Copy link
Contributor Author

ExPixel commented May 10, 2020

The constants can be found here: https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#machine-types . Seems to match up with what you already had for x86 and x86_64.

@m4b m4b merged commit 4bab2e7 into m4b:master May 10, 2020
@m4b
Copy link
Owner

m4b commented May 10, 2020

Awesome, appreciate the PR :)

@m4b
Copy link
Owner

m4b commented May 10, 2020

ok this along with unwrap is in 0.2.3 on crates.io, thanks for the PRs :)

@jan-auer
Copy link
Contributor

jan-auer commented May 11, 2020

FWIW, we also have the MachineType enum in pdb. If there are more cases like this, we could create a minimal pe crate that exposes these to both goblin and pdb. I'll keep an eye out for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants