Support exports without offset #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2021
dureuill
force-pushed
the
optional_offset
branch
from
d572412
to
f984749
Compare
|
Ran |
m4b
reviewed
Dec 9, 2021
Added detailed explanation for section_read_size function
dureuill
force-pushed
the
optional_offset
branch
from
f984749
to
3888c4b
Compare
m4b
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #292, which applies the change discussed there:
Option<_>inExport, and support when anExporthas no offset.Moreover, the correct commit of #292 (add missing subtraction) is retained.
Test
The same procedure as in #292 was followed.
This change does fix the issue #291 and the previously missing symbols are now returned for the tested binaries.
Thanks again for your time and consideration!