Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented Note #301

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Documented Note #301

merged 2 commits into from
Jan 22, 2022

Conversation

n01e0
Copy link
Contributor

@n01e0 n01e0 commented Jan 9, 2022

#300

In this PR we will work on documentation

m4b
m4b requested changes Jan 9, 2022
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the bit about section header string table mentioned and otherwise ready to go

src/strtab.rs Outdated Show resolved Hide resolved
src/strtab.rs Show resolved Hide resolved
@n01e0 n01e0 requested a review from m4b January 11, 2022 05:31
m4b
m4b approved these changes Jan 22, 2022
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, forgot about this, sorry for the delay!

@m4b m4b merged commit c7cd994 into m4b:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n01e0 @m4b