mach.parse: Handle DyldExportsTrie #303
Conversation
Fixes missing exports.
| @@ -294,6 +294,30 @@ impl<'a> ExportTrie<'a> { | |||
| location, | |||
| } | |||
| } | |||
|
|
|||
| /// Create a new, lazy, zero-copy export trie from the `LinkeditDataCommand` `command` | |||
| pub fn new_from_linkedit_data_command( | |||
There was a problem hiding this comment.
Presumably, we don't want a variation of the new function, but was simple to implement. What do you think?
There was a problem hiding this comment.
The name is kind of long, but fine; however, can you dispatch both of these implemenations to a new private constructor, say new_impl which takes the bytes + the offset + size, since that is how they only differ, e.g.:
fn new_impl(bytes: &'a [u8], offset: usize, size: usize) -> Self {
// etc.
}
pub fn new(bytes: &'a [u8], command: &load_command::DyldInfoCommand) -> Self {
Self::new_impl(bytes, command.export_off as usize, ommand.export_size as usize)
}
// one more using the LinkeditDataComand
| /// Create a new, lazy, zero-copy export trie from the `LinkeditDataCommand` `command` | ||
| pub fn new_from_linkedit_data_command( | ||
| bytes: &'a [u8], | ||
| command: &load_command::LinkeditDataCommand, |
There was a problem hiding this comment.
Unrelated to your PR< but i just noticed the capitalization for this is strange, surprised it's not LinkEditDataCommand; is this how it occurs in mach sources?
There was a problem hiding this comment.
Given it's LINKEDIT, not LINK_EDIT, I think the current capitalization makes sense?
| @@ -294,6 +294,30 @@ impl<'a> ExportTrie<'a> { | |||
| location, | |||
| } | |||
| } | |||
|
|
|||
| /// Create a new, lazy, zero-copy export trie from the `LinkeditDataCommand` `command` | |||
| pub fn new_from_linkedit_data_command( | |||
There was a problem hiding this comment.
The name is kind of long, but fine; however, can you dispatch both of these implemenations to a new private constructor, say new_impl which takes the bytes + the offset + size, since that is how they only differ, e.g.:
fn new_impl(bytes: &'a [u8], offset: usize, size: usize) -> Self {
// etc.
}
pub fn new(bytes: &'a [u8], command: &load_command::DyldInfoCommand) -> Self {
Self::new_impl(bytes, command.export_off as usize, ommand.export_size as usize)
}
// one more using the LinkeditDataComand
|
@apalm do you need a release urgently? I like to roll up a few of these non-breaking changes before another patch release |
|
@m4b Nope, not urgent :) |
|
What's src/.DS_Store for ? |
|
@lygstate good catch, sorry that i missed this :/ i've deleted it, though it's a bit sad it'll be in the git history forever; i could force push it out, but i don't think it's worth breaking anyone with an upstream clone |
|
actually, i've changed my mind, i'm going to force push it out |
* Fixes missing exports. * Add `new_impl` to `ExportTrie`
better add it into gitignore |
|
ok released in 0.5.2, thanks for your help! and thanks for your patience waiting for this! |
Fixes missing exports.