Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Plain for Nhdr{32,64} #317

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Implement Plain for Nhdr{32,64} #317

merged 1 commit into from
Jul 11, 2022

Conversation

mkroening
Copy link
Contributor

This implements Plain for both plain note headers.

What do you think?

m4b
m4b approved these changes Jul 11, 2022
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@m4b m4b merged commit 19519d0 into m4b:master Jul 11, 2022
@mkroening mkroening deleted the plain-nhdr branch July 11, 2022 09:42
@mkroening
Copy link
Contributor Author

Thanks for the quick review! A release with this would be awesome. :)

@m4b
Copy link
Owner

m4b commented Jul 18, 2022

0.5.3 has this release, on crates now; and thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @m4b