Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc warnings #395

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix doc warnings #395

merged 1 commit into from
Mar 18, 2024

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Mar 11, 2024

All of these were reported by cargo doc. (This should probably have a CI job set up to fail on warnings).

For the authenticode change, I figured it wasn't really that important to link to the method that the doc is on, so I just deleted that. And for the strtab change, the anchor hash at the end of the url didn't seem to link anywhere relevant?

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@m4b m4b merged commit 0aacaa7 into m4b:master Mar 18, 2024
6 checks passed
@m4b
Copy link
Owner

m4b commented Mar 18, 2024

if you would be interested in setting up a CI job for that, if it isn't too difficult, that would be nice; my only major concern would be if the error messages in CI aren't nice/good/helpful, this could increase difficulty for contributors perhaps

@m4b
Copy link
Owner

m4b commented Mar 18, 2024

release: non-breaking

@5225225 5225225 deleted the fix-docs branch March 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants