Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2018 edition #49

Merged
merged 3 commits into from
Apr 6, 2019
Merged

Upgrade to 2018 edition #49

merged 3 commits into from
Apr 6, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 5, 2019

This PR is based on decision from #40 of @m4b : #40 (comment)

@m4b
Copy link
Owner

m4b commented Apr 6, 2019

@lzutao thank you for this! I want to land this but I really wanted to see @willglynn PR here landed first, which was a really great improvement, namely it allows:

  1. pwriting extremely large values out of boxes, instead of on the stack (which will usually blow up the stack)
  2. better user/api ergonomics by not requiring owned values in pwrite calls.

Let me see what status is, if not maybe I or someone else can try to rebase and fix.

@m4b
Copy link
Owner

m4b commented Apr 6, 2019

actually this probably has minor conflicts? let me check

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one conflict, and it's minor, thanks again for pushing us into 2018 @lzutao :)

@m4b m4b merged commit 8a205d8 into m4b:master Apr 6, 2019
@tesuji tesuji deleted the 2018 branch April 6, 2019 18:47
m4b added a commit that referenced this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants