Added SizeWith impl for numeric types without Ctx. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
approved these changes
Aug 12, 2024
|
@Frostie314159 do you need a release with this and the size with for fixed size arrays? if not necessary I would prefer to wait to see if there's anything else pending, need to re-review the other pending PR here to see if it should be merged |
|
It's not urgent, it'd make one section of my code bit neater, but isn't required. |
Frostie314159
added a commit
to Frostie314159/scroll
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
SizeWithimpls for numeric types, without requiringEndianas context. It wasn't immediately clear, to me, why the ctx was required.