Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Mark generated functions as #[inline] #6

Merged
merged 1 commit into from
Apr 28, 2018
Merged

Mark generated functions as #[inline] #6

merged 1 commit into from
Apr 28, 2018

Conversation

Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Apr 26, 2018

This is needed to allow the code to be inlined across crates. This is part of my work to improve the performance of SymIterator in goblin.

@m4b
Copy link
Owner

m4b commented Apr 28, 2018

So looking at other derives like Default, and Eq, these all also annotate the implementation with inline, so I'm ok with do it here, as the user can explicitly implement if they don't want this behavior.

Thanks for the PR!

@m4b m4b merged commit 81153b1 into m4b:master Apr 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants