Fix startup crash on externally powered device (Axp) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not have any substantive code changes.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted line SetPeripheralsPower(true) within AXP192::begin() code which causes PowerOff on M5Core2 hardware powered externally via 5V Bus w/o USB cable connected.
The crash is caused by setting EXTEN to 1 within this statement before checking VBUS status if no usb cable is connected. The statement is completely obsolete as EXTEN will be enabled correctly anyway if v-bus status indicates that internal power is required (directly within the following if-statement).
Tested with ext. power, bat power and USB all doing well now.