Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: query select number #268
feat: query select number #268
Changes from all commits
6227e15
0082978
76ac83f
bbfdb71
c0bf438
6452b4e
f50f6a4
7b3b4aa
14621da
8f3a938
106b926
d580c0e
372655a
f555ae2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought Interesting component cause it looks very much like the native InputNumber from Antd but encapsulates some styling from the query-item and adds an errorMessage prop. I wonder if it couldn't be the case that we allow those customizations in the native InputNumber component although don't think we should have a "default" error rendering there so it kinda makes sense for this to live in it's own shell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes maybe, also this follows the pattern we establisher for the Query Item and having "sub components" that specify more specific variants of the ant components for the query builder specifically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought Not from this PR but I don't think we should get rid of the event payload here and pass only the value down. What if we need it in the future? Although this is would be a breaking change.