Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds README for UPS #302

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

Seebiscuit
Copy link
Collaborator

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Adds README for UPS

Testing Plan

N/A

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Seebiscuit Seebiscuit self-assigned this Jun 20, 2024
@Seebiscuit Seebiscuit requested a review from tibuurcio June 20, 2024 22:21
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a thought, let me know what you think.

src/services/user-preferences/README.md Outdated Show resolved Hide resolved

- `UserPreferences` and `CompositeUserPreferences` for modeling user preferences.
- `UserPreferenceScope` and `UserPreferenceDefinitions` for defining the scope and structure of preferences.
- `CompositeUserPreferencesService` for handling the composite nature of user preferences.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought This concept was difficult to grasp when I first started using the UPS. It took some time to understand what "composite" meant in practice. Maybe some more description here or even an example would help with this?

@tibuurcio tibuurcio self-requested a review June 24, 2024 15:24
Co-authored-by: Gabriel Tibúrcio <v-gtiburcio@mparticle.com>
@jared-dickman jared-dickman merged commit f80ea27 into main Jun 27, 2024
9 checks passed
tibuurcio added a commit that referenced this pull request Jun 28, 2024
Co-authored-by: Gary Kaganas <gkaganas@mparticle.com>
Co-authored-by: Gabriel Tibúrcio <v-gtiburcio@mparticle.com>
Co-authored-by: jared-dickman <zenador15@gmail.com>
mparticle-automation added a commit that referenced this pull request Aug 6, 2024
# [1.24.0-chore-cascader-loading-state.1](v1.23.0...v1.24.0-chore-cascader-loading-state.1) (2024-08-06)

### Features

* adds README for UPS ([#302](#302)) ([f80ea27](f80ea27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.24.0-chore-cascader-loading-state.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Aug 26, 2024
# [1.29.0-chore-cascader-updates.1](v1.28.1...v1.29.0-chore-cascader-updates.1) (2024-08-26)

### Bug Fixes

* allow any component as a Label, include placement prop in base cascader ([16f9d0d](16f9d0d))
* update nav link active background color ([#376](#376)) ([3965e60](3965e60))

### Features

* adds README for UPS ([#302](#302)) ([f80ea27](f80ea27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.29.0-chore-cascader-updates.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Aug 30, 2024
# [1.30.0-chore-cascader-updates.1](v1.29.0...v1.30.0-chore-cascader-updates.1) (2024-08-30)

### Bug Fixes

* allow any component as a Label, include placement prop in base cascader ([16f9d0d](16f9d0d))
* input display when selecting a reactNode label ([b691903](b691903))

### Features

* add searchLabel to queryItemCascader, and defaultOpen prop ([bb80cdc](bb80cdc))
* adds README for UPS ([#302](#302)) ([f80ea27](f80ea27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.30.0-chore-cascader-updates.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Sep 5, 2024
# [1.31.0-chore-cascader-updates.1](v1.30.1...v1.31.0-chore-cascader-updates.1) (2024-09-05)

### Bug Fixes

* allow any component as a Label, include placement prop in base cascader ([16f9d0d](16f9d0d))
* input display when selecting a reactNode label ([b691903](b691903))

### Features

* add searchLabel to queryItemCascader, and defaultOpen prop ([bb80cdc](bb80cdc))
* adds README for UPS ([#302](#302)) ([f80ea27](f80ea27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.31.0-chore-cascader-updates.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants