Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification center export z-index #422

Merged
merged 5 commits into from
Sep 23, 2024
Merged

fix: notification center export z-index #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc4fede
fix: export zIndex
Sep 20, 2024
bf4c746
chore(release): 1.32.0-fix-notification-center-export-zindex.1 [skip ci]
mparticle-automation Sep 20, 2024
c74a701
revert: package version
Sep 20, 2024
3e95f90
revert: package-lock version
Sep 20, 2024
a461797
Merge branch 'main' into fix/notification-center-export-zindex
Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# [1.32.0-fix-notification-center-export-zindex.1](https://github.com/mParticle/aquarium/compare/v1.31.1...v1.32.0-fix-notification-center-export-zindex.1) (2024-09-20)

### Bug Fixes

- export zIndex ([dc4fede](https://github.com/mParticle/aquarium/commit/dc4fede4cfb350de5dbeb2587e8d7599ffc0df04))

### Features

- add datepicker example ([#408](https://github.com/mParticle/aquarium/issues/408)) ([0b4b46b](https://github.com/mParticle/aquarium/commit/0b4b46b201986cc240224142a308e76186133821))

## [1.31.1](https://github.com/mParticle/aquarium/compare/v1.31.0...v1.31.1) (2024-09-18)

### Bug Fixes
Expand Down
4 changes: 2 additions & 2 deletions src/components/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ export type {
IWorkspaceSelectorDisplayItem,
IWorkspaceSelectorItem,
} from './navigation/GlobalNavigation/WorkspaceSelector/WorkspaceSelectorItems'
export type {
INotificationCenterProps,
export {
type INotificationCenterProps,
Comment on lines +112 to +113
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird, type is only applying to INotificationCenterProps here and seems like NotificationCenterZIndex was already being exported. @leobel were you able to validate this in the platforms with the feature version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did validate it. I don't know what you mean by 'weird', we have other places where doing practically the same:

export {
  type UserPreferences,
  USER_PREFERENCE_SCOPE_SEPARATOR,
  UserPreferenceGlobalScope,
  type UserPreference,
  type UserPreferenceScope,
} from '../services/user-preferences/models/storage-models'

Copy link
Collaborator

@tibuurcio tibuurcio Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think I got it. Meant weird not because of the usage of type but because the PR talks about fixing the z-index export but at first glance it is changing the INotificationCenterProps. But it's actually changing only zIndex.

So before, both INotificationCenterProps and NotificationCenterZIndex were being exported as types. This PR is changing NotificationCenterZIndex, is now exported as a value and only INotificationCenterProps is kept as a type. That's the correct behaviour right? That's hard to understand at first sorry about the confusion!

With that, this is safe for approval 👍🏼

NotificationCenterZIndex,
} from './navigation/GlobalNavigation/NotificationCenter'
export { SuiteLogo } from './navigation/GlobalNavigation/SuiteLogo'
Expand Down
Loading