Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a background color to test nested css #428

Closed
wants to merge 8 commits into from

Conversation

gabyzif
Copy link
Contributor

@gabyzif gabyzif commented Sep 26, 2024

Summary

  • Integrated PostCSS with postcss-nesting to handle CSS nesting in the Vite build.
  • Updated vite.config.js to support ESM imports for PostCSS plugins.
  • Ensured proper CSS processing and compatibility with legacy projects.

Testing Plan

This PR ENV has an example of it working (using a background color as an example)

Before adding nested css, when building Nancy localy for Prod the console will show this warning:

Screenshot 2024-09-30 at 3 48 29 PM

after (no warning):

Screenshot 2024-09-30 at 3 50 56 PM
  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@ilyusha
Copy link
Collaborator

ilyusha commented Sep 26, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://mParticle.github.io/aquarium/pr-preview/pr-428/
on branch gh-pages at 2024-09-30 13:56 UTC

@gabyzif gabyzif changed the title fix: add a background color to test css fix: add a background color to test nested css Sep 26, 2024
@gabyzif gabyzif closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants