Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new docs regarding testing in the platforms #429

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

tibuurcio
Copy link
Collaborator

Summary

  • This PR adds a build command that fixes one of the issues with local linking in the platforms. We were not including the styles files in the dist/ folder when running npx vite build manually so platforms were missing it.

It also changes docs to reflect latest instructions.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue

@tibuurcio tibuurcio requested a review from gabyzif September 26, 2024 22:58
@ilyusha
Copy link
Collaborator

ilyusha commented Sep 26, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-27 13:55 UTC

Copy link
Contributor

@gabyzif gabyzif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!! the pr link looks amazing

@tibuurcio tibuurcio merged commit 5c5e3ce into main Sep 27, 2024
11 of 12 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.33.0-fix-nested-css-error.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.33.0-ant-update.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants