Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create doc files for components and add an image example #441

Merged
merged 1 commit into from
Oct 7, 2024
Merged

docs: create doc files for components and add an image example #441

merged 1 commit into from
Oct 7, 2024

Conversation

tibuurcio
Copy link
Collaborator

Summary

  • This PR adds MDX documentation files for some core components (request from design) and also adds an image as an example on how to display images in MDX.

Testing Plan

  • Was this tested locally? If not, explain why.

@ilyusha
Copy link
Collaborator

ilyusha commented Oct 7, 2024

Review Forge

Click Here for AI Insights

@tibuurcio
Copy link
Collaborator Author

Merging this without approvals since it's only docs changes and it's a request from the Design team.

@tibuurcio tibuurcio merged commit b22d3cd into main Oct 7, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://mParticle.github.io/aquarium/pr-preview/pr-441/
on branch gh-pages at 2024-10-07 19:28 UTC

@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.33.1-chore-add-styles-from-nancy.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibuurcio @ilyusha @mparticle-automation