Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StreamType.LIVE_STREAM typo #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: StreamType.LIVE_STREAM typo #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion media/src/main/java/com/mparticle/media/events/StreamType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.mparticle.media.events

object StreamType {
const val LIVE_STEAM = "LiveStream"
const val LIVE_STREAM = "LiveStream"
const val ON_DEMAND = "OnDemand"
const val LINEAR = "Linear"
const val PODCAST = "Podcast"
Expand Down
4 changes: 1 addition & 3 deletions media/src/test/java/com/mparticle/APISampleJava.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
import org.junit.Before;
import org.junit.Test;

import java.util.HashMap;

import kotlin.Unit;
import kotlin.jvm.functions.Function1;

Expand All @@ -23,7 +21,7 @@ public void before() {
.title("Media Title ")
.mediaContentId("abc123")
.contentType(ContentType.AUDIO)
.streamType(StreamType.LIVE_STEAM)
.streamType(StreamType.LIVE_STREAM)
.build();
}

Expand Down
2 changes: 1 addition & 1 deletion media/src/test/java/com/mparticle/APISampleKotlin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class APISampleKotlin {
title = "Media Title"
mediaContentId = "123"
duration = 1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = false
Expand Down
17 changes: 8 additions & 9 deletions media/src/test/java/com/mparticle/MediaSessionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package com.mparticle
import com.mparticle.media.MediaSession
import com.mparticle.media.events.*
import com.mparticle.testutils.RandomUtils
import com.mparticle.testutils.TestingUtils
import junit.framework.Assert.*
import org.junit.Test
import java.lang.reflect.Method
Expand All @@ -23,7 +22,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = random.nextBoolean()
Expand All @@ -50,7 +49,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = false
Expand All @@ -74,7 +73,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = true
Expand All @@ -96,7 +95,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId = "123"
duration = 1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO
}

Expand Down Expand Up @@ -125,7 +124,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId = "123"
duration = 1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO
}

Expand Down Expand Up @@ -164,7 +163,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = false
Expand Down Expand Up @@ -281,7 +280,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = random.nextBoolean()
Expand Down Expand Up @@ -348,7 +347,7 @@ class MediaSessionTest {
title = "hello"
mediaContentId ="123"
duration =1000
streamType = StreamType.LIVE_STEAM
streamType = StreamType.LIVE_STREAM
contentType = ContentType.VIDEO

logMediaEvents = random.nextBoolean()
Expand Down