Refactor with rector to support PHP 8.3 #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code change removed the entity specification, leaving only the type specification in the DbQuery within the AlpsQueryInterface. This simplifies the DbQuery annotation by removing potentially redundant information.
The "require" field in composer.json has been modified to bump up the required PHP version. This change updates the minimum PHP version requirement from "^8.1" to "^8.3".
A new file named rector.php has been added. This file includes a basic structure for the configuration of Rector, including paths to cover and specific rules to apply. It focuses on a rule called "AddVoidReturnTypeWhereNoReturnRector".
…rRide' attributes The code changes have updated several class properties and methods across multiple files in the application. Classes are now marked with 'readonly', indicating that their properties cannot be changed after initialization. Additionally, various class methods have been marked with '@OverRide', specifying they are overriding a method in a superclass.
This update expands the rector configuration by adding prepared sets. These include instanceOf, privatization, codeQuality, strictBooleans, typeDeclarations, and deadCode, enabling a broader range of code checks and optimizations.
The code has been refined to simplify the casting of getenv result in 'TestModule.php'. Furthermore, an instance of 'ResourceInterface' on 'StateDiagramTest.php' has been removed to eliminate redundancy. The URL function in 'HttpLinkFactory.php' has been updated to indicate it may return an array or a string to make it clearer.
The code update removes the fully qualified name (\Override) in all Override annotations across multiple project files. Instead, it imports the Override class at the top of each file to shorten the syntax. This modification improves the clarity and conciseness of the codebase.
This commit removes a specific ignoreError rule from phpstan-baseline.neon configuration. The previously ignored error related to an unused property in the StateDiagramTest has been rectified.
This commit upgrades multiple dependencies in the vendor-bin/tools including 'vimeo/psalm' and 'amphp/amp' versions. It also removes the 'psalm/plugin-phpunit' dependency. Moreover, the commit introduces adjustments in the composer.lock file reflecting the versions updates and dependencies removal.
Suppressed a Psalm warning in the httpCache conditional check in Bootstrap.php. Ensured type safety in TestModule.php and HttpLinkFactory.php by explicitly casting environment variable to string and specifying function parameter and return types.
This commit updates the specified PHP version in the continuous integration, static analysis, and coding standards GitHub workflows. The PHP version has been upgraded from 8.1 to 8.3, allowing the project to use the new features and optimizations from the updated version.
The commit modifies the LINK_TEMPLATE constant in the AlpsLink class. The code was updated to ignore PHP Code Sniffer (phpcs) for this line, in order to preserve the formatting necessary for functional operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.