New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not publish_state when underlying climateguard/RadSens library returns 0 for unknown value #4

Merged

maaad merged 1 commit into maaad:main from bakerkj:bakerkj-ignore-errors

Oct 30, 2022

Contributor

bakerkj commented Oct 29, 2022 •

edited

Loading

The underlying climateguard/RadSens library returns 0 in case of error for both getRadIntensyDynamic() and getRadIntensyStatic().

As can be seen here https://github.com/climateguard/RadSens/blob/8323ad694bf10ec0a462e240815e8f31c517cf65/src/CG_RadSens.cpp

/*Get radiation intensity (dynamic period T < 123 sec).*/
float CG_RadSens::getRadIntensyDynamic()
{
    updatePulses();
    uint8_t res[3];
    if (i2c_read(RS_RAD_INTENSY_DYNAMIC_RG, res, 3))
    {
        float temp = (((uint32_t)res[0] << 16) | ((uint16_t)res[1] << 8) | res[2]) / 10.0;
        return temp;
    }
    else
    {
        return 0;
    }
}

This pull request skips publishing these erroneous values. This should address some of the issues identified in #3.


          The underlying climateguard/RadSens library returns 0 in case of

c118376

error; Treat these as unknown values and don't publish a value.

maaad merged commit 4259da1 into maaad:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet