Merge pull request #681 from mabel-dev/FIX/#518

#518
mabel-dev · Nov 23, 2022 · 8b634c1 · 8b634c1
2 parents d75c1e5 + 9ab2d5f
commit 8b634c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/opteryx/operators/aggregate_node.py b/opteryx/operators/aggregate_node.py
@@ -238,6 +238,8 @@ def __init__(self, properties: QueryProperties, **config):
         super().__init__(properties=properties)
 
         self._aggregates = config.get("aggregates", [])
+        if any(node.token_type == NodeType.WILDCARD for node in self._aggregates):
+            raise SqlError("Cannot select `*` with `GROUP BY` clause.")
 
         self._groups = []
         for group in config.get("groups", []):

diff --git a/tests/sql_battery/test_shapes_and_errors_battery.py b/tests/sql_battery/test_shapes_and_errors_battery.py
@@ -794,6 +794,8 @@
         ("SELECT * FROM $planets WHERE 1 = 1 FOR TODAY;", None, None, SqlError),
         ("SELECT * FROM $planets GROUP BY name FOR TODAY;", None, None, SqlError),
         ("SELECT * FROM $planets AS P FOR TODAY;", None, None, SqlError),
+        # [#518] SELECT * and GROUP BY can't be used together
+        ("SELECT * FROM $planets GROUP BY name", None, None, SqlError),
 ]
 # fmt:on