Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Python 3.10 regression fails #98

Closed
joocer opened this issue May 7, 2022 · 3 comments
Closed

[BUG] Python 3.10 regression fails #98

joocer opened this issue May 7, 2022 · 3 comments
Assignees
Labels
Bug 🪲 Something isn't working

Comments

@joocer
Copy link
Contributor

joocer commented May 7, 2022

see results:
https://github.com/mabel-dev/opteryx/actions/runs/2287677990

Other versions do not fail

@joocer joocer added the Bug 🪲 Something isn't working label May 7, 2022
@joocer joocer self-assigned this May 7, 2022
@joocer
Copy link
Contributor Author

joocer commented May 8, 2022

Appears to be related to NULL records not be deduplicated

@joocer
Copy link
Contributor Author

joocer commented May 8, 2022

This may be related to this change in Python 3.10

Hashes of NaN values of both [float](https://docs.python.org/3/library/functions.html#float) type and [decimal.Decimal](https://docs.python.org/3/library/decimal.html#decimal.Decimal) type now depend on object identity. Formerly, they always hashed to 0 even though NaN values are not equal to one another. This caused potentially quadratic runtime behavior due to excessive hash collisions when creating dictionaries and sets containing multiple NaNs. (Contributed by Raymond Hettinger in [bpo-43475](https://bugs.python.org/issue?@action=redirect&bpo=43475).)

https://docs.python.org/3/whatsnew/3.10.html

joocer added a commit that referenced this issue May 8, 2022
@joocer
Copy link
Contributor Author

joocer commented May 8, 2022

FIXED

@joocer joocer closed this as completed May 8, 2022
joocer added a commit that referenced this issue May 10, 2022
joocer added a commit that referenced this issue May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant